Skip to content

adding tests and cmake support#1

Merged
kolemannix merged 15 commits intokolemannix:mainfrom
lemire:main
Mar 5, 2026
Merged

adding tests and cmake support#1
kolemannix merged 15 commits intokolemannix:mainfrom
lemire:main

Conversation

@lemire
Copy link
Contributor

@lemire lemire commented Mar 4, 2026

No description provided.

@kolemannix
Copy link
Owner

This is so great, thank you. The CMake fetch content currently points to your fork; would you like to keep it that way or use this one eventually

@lemire
Copy link
Contributor Author

lemire commented Mar 4, 2026

The CMake fetch content currently points to your fork; would you like to keep it that way or use this one eventually

I don't think it does...

FetchContent_Declare(supplemental_test_files
  GIT_REPOSITORY https://github.com/fastfloat/supplemental_test_files.git
  GIT_TAG origin/main)

Where does this data come from? I was puzzled by this in fast_float

It comes from https://github.com/fastfloat/supplemental_test_files.git

The idea is that instead of dropping lots of heavy data files directly in your repo, you pull them out if you want to test exhaustively the code.

@lemire lemire requested a review from kolemannix March 4, 2026 22:35
@lemire lemire requested a review from kolemannix March 5, 2026 18:43
@lemire
Copy link
Contributor Author

lemire commented Mar 5, 2026

@kolemannix I recommend merging.

@kolemannix kolemannix merged commit 1998be0 into kolemannix:main Mar 5, 2026
5 checks passed
@kolemannix
Copy link
Owner

I recommend merging.

Well that's the idea of a pull request isn't it!

Merged

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants